chore(deps): update dependency nvidia/openshell to v0.0.116 - #6737
Conversation
|
🤖 Finished Review · ✅ Success · Started 7:21 PM UTC · Completed 7:31 PM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $1.76 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Risk Assessment: moderate (2/5) DetailsScore unchanged from prior assessment at 2 (moderate). PR now touches 4 files (up from 1 in prior review) but the 3 added files are trivial 1-line version string bumps in docs and hack scripts. Tier 1 remains low (1.38) driven by the single protected path (.github/). Tier 2 is elevated (2.75) due to high churn and fix/revert counts on the docs file, though these reflect routine automated updates rather than instability. Tier 3 confirms the PR directly resolves issue #6707 (broken macOS binaries). Composite 1.81 rounds to 2 (moderate). Previous runRisk Assessment: moderate (2/5) DetailsTrivial 4-line version bump by Renovate bot in a single script file (.github/scripts/openshell-version.sh). Tier 1 is very low (1.25) driven only by the protected path (.github/). Tier 2 is elevated (2.75) due to multi-author contention and fix/revert history on this file, though these reflect routine automated version bumps rather than true instability. Composite 1.82 rounds to 2 (moderate). |
ReviewFindingsMedium
Previous runReviewFindingsHigh
Next steps:
|
Renovate only tracks .github/scripts/openshell-version.sh. The runner VM
fallbacks in hack/gitlab-runner-vm/{create-vm,setup}.sh and the install
snippet in docs/guides/user/running-agents-locally.md carry the same
version by hand and were left at 0.0.115, so move them together with the
pin as #6696 did.
The docs snippet matters beyond consistency: 0.0.115's Apple Silicon
binaries were linked against a Nix store libiconv and could not start
(NVIDIA/OpenShell#2997), and the guide pointed macOS users at exactly
that build. 0.0.116 ships the upstream fix (NVIDIA/OpenShell#3006), so
pointing the guide at it resolves the macOS install path.
Closes #6707
Assisted-by: Claude
Signed-off-by: Wayne Sun <gsun@redhat.com>
|
Added The docs line is the one that matters: 0.0.115's Apple Silicon binaries could not start (NVIDIA/OpenShell#2997, fixed upstream in NVIDIA/OpenShell#3006 and shipped in 0.0.116), and the guide pointed macOS users at that build. The commit carries Note for Renovate: a non-bot commit is now on this branch, so it will stop rebasing it automatically; tick the rebase checkbox only if you want to discard the extra commit. |
|
🤖 Review · ❌ Terminated · Started 8:07 PM UTC · Ended 8:21 PM UTC Commit: |
Site previewPreview: https://1112319a-site.fullsend-ai.workers.dev Commit: |
Superseded by updated review
|
🤖 Finished Review · ✅ Success · Started 8:07 PM UTC · Completed 8:21 PM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $3.59 |
waynesun09
left a comment
There was a problem hiding this comment.
Renovate pin bump to OpenShell 0.0.116 plus the hand-maintained mirrors (runner VM fallbacks, local-run guide) moved in the same PR. OPENSHELL_SHA matches the v0.0.116 tag commit. v0.0.115→v0.0.116 contains only the macOS binary normalization (NVIDIA/OpenShell#3006), a shutdown log reclassification, and test/dev-script changes — nothing in the proxy, providers, or sandbox lifecycle. CI on this head installed 0.0.116 and passed functional-tests (4/4), e2e, and behaviour.
|
🤖 Finished Retro · ✅ Success · Started 8:41 PM UTC · Completed 9:00 PM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $7.19 |
Retro: PR #6737 — OpenShell dependency bump (0.0.115 → 0.0.116)Workflow summary: Renovate opened a 1-file version bump. The review agent flagged Verdict: workflow functioned correctly. The protected-path gate worked as designed — it surfaced a governance-relevant file change, a human reviewed and approved it, and the PR merged with all CI checks passing. No bugs, no missed findings, no false negatives. No new proposals filed. All improvement opportunities identified are already covered by existing open issues:
|
This PR contains the following updates:
0.0.115→0.0.116Release Notes
NVIDIA/OpenShell (NVIDIA/OpenShell)
v0.0.116: OpenShell v0.0.116Compare Source
OpenShell v0.0.116
Quick install
curl -LsSf https://raw.githubusercontent.com/NVIDIA/OpenShell/main/install.sh | OPENSHELL_VERSION=v0.0.116 shWhat's Changed
Full Changelog: NVIDIA/OpenShell@v0.0.115...v0.0.116
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate.